Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpringBoot] Migrate to GA #8223

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

milan-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

Migrates the integration from BETA to GA.

Related issues

@milan-elastic milan-elastic self-assigned this Oct 17, 2023
@milan-elastic milan-elastic marked this pull request as ready for review October 17, 2023 07:27
@milan-elastic milan-elastic requested a review from a team as a code owner October 17, 2023 07:27
@elasticmachine
Copy link

elasticmachine commented Oct 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T06:29:31.183+0000

  • Duration: 18 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.316
Classes 100.0% (2/2) 💚 3.316
Methods 100.0% (27/27) 💚 7.875
Lines 93.671% (148/158) 👍 5.239
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compatibility check is done with v2.3.12 for this integrations and the latest spring boot version is 3.1.x. After 2.3.x there are updates related to the dependencies and also bug-fixes. Can we perform compatibility check with the latest stable release and update the document?

@milan-elastic
Copy link
Contributor Author

The compatibility check is done with v2.3.12 for this integrations and the latest spring boot version is 3.1.x. After 2.3.x there are updates related to the dependencies and also bug-fixes. Can we perform compatibility check with the latest stable release and update the document?

@muthu-mps While setting up the latest Spring Boot version 3.1.5 found that for the httptrace data stream containing httptrace endpoint has been removed. Instead of httptrace, found that there is one another endpoint httpexchanges is as same as httptrace that is currently supported in the Spring Boot 2.3.12.
For other data streams (GC, Threading and Memory) they are using the /actuator/jolokia which seems not supported in the current latest release of 3.1.5.
For auditevents, the endpoint seems to work as expected as it was previously in 2.3.12.
Let me know how should we proceed in this case!
CC: @SubhrataK @lalit-satapathy

@milan-elastic
Copy link
Contributor Author

While setting up Spring Boot for v2.7.17 we checked that if all the data streams are working as expected. We also had to check the same with various LTS releases of JDK. Sharing the details of all below.

JDK 8

  • Verified that all the data streams are working properly

JDK 11, 17 & 21

For the Springboot v3.1.5, Following datastreams are not supported, please find the issue for it: #8318

  • GC
  • Memory
  • Threading
  • Http trace

CC: @SubhrataK @muthu-mps @lalit-satapathy @tommyers-elastic

@shmsr
Copy link
Member

shmsr commented Oct 27, 2023

Could you please rebase with main? You have an older checkout i.e., package-spec v3 changes are there which is not in your branch. Please do the rebase to the latest of main and test on top of that if you are doing any testing.

@muthu-mps muthu-mps self-requested a review October 31, 2023 05:47
@milan-elastic milan-elastic merged commit 9758f9c into elastic:main Nov 1, 2023
1 check passed
@elasticmachine
Copy link

Package spring_boot - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y] Make Springboot GA
5 participants